This repository was archived by the owner on Mar 27, 2025. It is now read-only.
fix: Update barretenberg to version with mutex on pedersen generators#21
Merged
fix: Update barretenberg to version with mutex on pedersen generators#21
Conversation
- Remove test_threads=1 setting
kevaundray
changed the title
Contributor
Author
|
Will push this forward once noir-lang/noir#1114 is merged |
phated
previously approved these changes
Apr 21, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
I tested this in noir tests and the noir integration tests finish in 1 minute. I'm so hyped! Now to get binary cache for the bb builds 🚀
phated
approved these changes
Apr 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates barretenberg to the latest commit, which adds a mutex around the init function for global generators.
This should allow us to remove the test_threads=1 limitation.